Skip to content

Conversation

khushi-411
Copy link
Contributor

No description provided.

@ubaidsk
Copy link
Collaborator

ubaidsk commented Mar 7, 2024

@khushi-411 Can you add tests for this?

@khushi-411 khushi-411 changed the title [asr->python] add complex visitors [asr->python] add complex, string{item, section} visitors Mar 7, 2024
@ubaidsk
Copy link
Collaborator

ubaidsk commented Mar 7, 2024

I would suggest focusing on one particular support in this PR. For example, either complex visitors or string visitors. And then add good tests for it. We can support the other visitors (for example string visitors) in a separate PR.

@khushi-411 khushi-411 changed the title [asr->python] add complex, string{item, section} visitors [asr->python] add complex visitors Mar 8, 2024
@ubaidsk
Copy link
Collaborator

ubaidsk commented Mar 8, 2024

Good. Now we need to add tests that test each of the implemented visitor.

@Thirumalai-Shaktivel
Copy link
Collaborator

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants